Skip to content

docs(cookbook): network requests recipes #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

vanGalilea
Copy link
Contributor

Summary

Compose Network Requests recipes as part of our Cookbook docs

Test plan

Sanity check Cookbook app

  • Run the Cookbook app > Click on "Phonebook.."
  • Verify rendering of contact and favorites list

Sanity check recipes docs

  • Run the website app
  • Ensure you can navigate to "Network Requests Recipes"
  • Read and review "Axios" & "Fetch" recipes

Possible spin offs

  • Add an 'msw' recipe under the "Network Requests Recipes" sec.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (a282d1e) to head (1ca49e0).
Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1651      +/-   ##
==========================================
+ Coverage   95.51%   95.53%   +0.01%     
==========================================
  Files          99      101       +2     
  Lines        5400     5508     +108     
  Branches      857      550     -307     
==========================================
+ Hits         5158     5262     +104     
- Misses        242      246       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


jest.mock('axios');

jest.setTimeout(10000);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this test suit runs in CI, the default 5s is not sufficient.
Locally it's a matter of 0.91 s.

Any idea what might be causing this on CI? @mdjastrzebski?

@vanGalilea vanGalilea closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant